fix: display skip reason in new ui #618
Conversation
| @@ -109,6 +110,23 @@ function MetaInfoInternal(props: MetaInfoInternalProps): ReactNode { | |||
| }); | |||
| } | |||
|
|
|||
| const shouldAddSkipReason = Boolean(!metaInfoItemsWithResolvedUrls.find(item => item.label === 'muteReason')); | |||
There was a problem hiding this comment.
I would use a separate variable for this expression - Boolean(!metaInfoItemsWithResolvedUrls.find(item => item.label === 'muteReason')). For example - hasMuteReason
There was a problem hiding this comment.
We discussed this with sipayrt and decided that it's not very good idea to include such specific logic related to muteReason, so i got rid of altogether
| content: reason.props.children, | ||
| url: reason.props.href | ||
| }); | ||
| } |
There was a problem hiding this comment.
can reason be something else? I mean is there a condition under which the value does not fall into any of the described conditions (if and else if).
There was a problem hiding this comment.
This logic is no longer here.
| label: 'skipReason', | ||
| content: reason | ||
| }); | ||
| } else if (!Array.isArray(reason) && typeof reason.props.children === 'string' && typeof reason.props.href === 'string') { |
There was a problem hiding this comment.
This is no longer here, got rid of parsing html entirely.
| if (props.item.images?.length) { | ||
| if (props.item.skipReason) { | ||
| return <div className={styles.skipReasonContainer}> | ||
| <div className={styles.skipReason}>Skipped ⋅ {Parser(props.item.skipReason)}</div> |
There was a problem hiding this comment.
⋅ - why you choose a dot as a separator? But in IU it looks quite harmonious. Maybe you use it in some other components?
There was a problem hiding this comment.
I think it looks nice as a separator and it's not the only place we use dot. The other places are hint toast, and other variants of subtitle in tree view.
shadowusr
force-pushed
the
users/shadowusr/TESTPLANE-335
branch
from
1018dba to
dd1119d
Compare
What's done:
Demo report: https://nda.ya.ru/t/Ba_4zPC979ttwt